Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ipcpath arg default #4036

Merged
merged 1 commit into from
Aug 2, 2023
Merged

chore: make ipcpath arg default #4036

merged 1 commit into from
Aug 2, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 2, 2023

make it non optional so default is displayed in --help msg

@mattsse mattsse requested a review from onbjerg as a code owner August 2, 2023 15:26
@mattsse mattsse requested a review from rkrasiuk August 2, 2023 15:27
@mattsse mattsse added the A-cli Related to the reth CLI label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4036 (cf892af) into main (88f83fc) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 75.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/rpc_server_args.rs 54.27% <75.00%> (-0.15%) ⬇️

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.47% <0.00%> (-0.03%) ⬇️
unit-tests 64.16% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.83% <75.00%> (-0.01%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 90.13% <ø> (+0.03%) ⬆️
storage (db) 74.33% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 47.36% <ø> (-0.63%) ⬇️
networking 77.43% <ø> (-0.03%) ⬇️
rpc 58.28% <ø> (-0.01%) ⬇️
consensus 63.55% <ø> (+0.04%) ⬆️
revm 32.71% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.00% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit d595834 Aug 2, 2023
@mattsse mattsse deleted the matt/make-ipc-path-default branch August 2, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants